Repository navigation
pcan: keep a received frame read with a bus-load warning - #2130
Open
adambodurka-lime wants to merge 2 commits into
Open
adambodurka-lime wants to merge 2 commits into
adambodurka-lime wants to merge 2 commits into
Conversation
PCAN-Basic can report BUSLIGHT or BUSHEAVY together with a frame it received. PcanBus dropped the frame in that case. Keep it when those are the only flags and the message is not a status or error frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PcanBusdrops a received frame whenRead()also reportsPCAN_ERROR_BUSLIGHTorPCAN_ERROR_BUSHEAVY. This keeps the frame when those are the only flags and the message is a data frame. Status frames, error frames and other errors are handled as before.Type of Change
Checklist
tox). Rantest/test_pcan.pyandblack --checkonly.🤖 Generated with Claude Code